commit a81bb956c039b6e4d155bc6917873db6a8d4f864
author janakr <janakr@google.com> Mon Jan 28 17:30:06 2019 -0800
committer Copybara-Service <copybara-piper@google.com> Mon Jan 28 17:32:19 2019 -0800
tree 50cb2ccb2b0cc6a1e4ba6bd38fd076b4b7d1acf5
parent fdb17eb11a9cef758544844add21decfd1d32b65

Add a "nonce version" fingerprint to ActionLookupValue, potentially populated for the ActionLookupValues that need it: *ConfiguredTargetValue and AspectValue. These need it because they contain objects that use reference equality for comparisons (notably, CcLinkingParams). Following an idea coming from shahan@.

PiperOrigin-RevId: 231319823

src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
index a4532c8..46e7d4b 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
@@ -70,4 +70,9 @@
    * called.
    */
   void clear(boolean clearEverything);
+
+  @Override
+  default boolean mustBeReferenceComparedOnRecomputation() {
+    return true;
+  }
 }