commit a86c267ed31999f6e6f6d5f206526775b804d3a0
author janakr <janakr@google.com> Mon Jun 18 09:04:43 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Jun 18 09:06:08 2018 -0700
tree aa41f6962ece19816054032af63c18f6126ba34f
parent ba2f39140735948e83168de7e8124cddc477d0f1

Make ConfiguredTargetValue a NotComparableSkyValue. Since no implementation of ConfiguredTarget implements equality, it's very much not comparable.

PiperOrigin-RevId: 201004116

src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
index b527d59..622491b 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetValue.java
@@ -22,14 +22,13 @@
 import com.google.devtools.build.lib.cmdline.Label;
 import com.google.devtools.build.lib.collect.nestedset.NestedSet;
 import com.google.devtools.build.lib.packages.Package;
+import com.google.devtools.build.skyframe.NotComparableSkyValue;
 import com.google.devtools.build.skyframe.SkyKey;
 import com.google.devtools.build.skyframe.SkyValue;
 import java.util.List;
 
-/**
- * A {@link SkyValue} for a {@link ConfiguredTarget}.
- */
-public interface ConfiguredTargetValue extends SkyValue {
+/** A {@link SkyValue} for a {@link ConfiguredTarget}. */
+public interface ConfiguredTargetValue extends NotComparableSkyValue {
   static SkyKey key(Label label, BuildConfiguration configuration) {
     return ConfiguredTargetKey.of(label, configuration);
   }