commit ac6d4fd194c2d9aba13ce613ec373f627210b18d
author mschaller <mschaller@google.com> Wed Feb 27 14:01:44 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Feb 27 14:03:23 2019 -0800
tree 9970da6ba4017469f429a39c04f07e6a7831ea02
parent 89299bd2b1ec6e1ce27c6d0e745aed6aae9907d7

Meaningfully name a local variable in addReverseDepAndCheckIfDone

Also flips the meaning of the boolean variable for more positivity.

RELNOTES: None.
PiperOrigin-RevId: 235987215

src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
index 233127d..02ecef8 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -387,11 +387,11 @@
     if (dirtyBuildingState == null) {
       dirtyBuildingState = DirtyBuildingState.createNew();
     }
-    boolean result = !dirtyBuildingState.isEvaluating();
-    if (result) {
+    boolean wasEvaluating = dirtyBuildingState.isEvaluating();
+    if (!wasEvaluating) {
       dirtyBuildingState.startEvaluating();
     }
-    return result ? DependencyState.NEEDS_SCHEDULING : DependencyState.ALREADY_EVALUATING;
+    return wasEvaluating ? DependencyState.ALREADY_EVALUATING : DependencyState.NEEDS_SCHEDULING;
   }
 
   /** Sets {@link #reverseDeps}. Does not alter {@link #reverseDepsDataToConsolidate}. */