commit ace678e16def33a94ad1cb3bec7336d894510272
author Dmitry Lomov <dslomov@google.com> Wed Dec 16 15:10:20 2015 +0000
committer Damien Martin-Guillerez <dmarting@google.com> Wed Dec 16 15:31:44 2015 +0000
tree f83705c727e7af498cc2e2ad0e75020d866d14c0
parent 8853df9a19dabc72c3b723b84e6cb69b6fb2884e

Implement aspect attributes and expose them to aspect implementation function.

--
MOS_MIGRATED_REVID=110356954

src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java b/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
index 15829d8..763ae11 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/AspectDefinition.java
@@ -250,6 +250,17 @@
      */
     public <TYPE> Builder add(Attribute.Builder<TYPE> attr) {
       Attribute attribute = attr.build();
+      return add(attribute);
+    }
+
+    /**
+     * Adds an attribute to the aspect.
+     *
+     * <p>Since aspects do not appear in BUILD files, the attribute must be either implicit
+     * (not available in the BUILD file, starting with '$') or late-bound (determined after the
+     * configuration is available, starting with ':')
+     */
+    public Builder add(Attribute attribute) {
       Preconditions.checkState(attribute.isImplicit() || attribute.isLateBound());
       Preconditions.checkState(!attributes.containsKey(attribute.getName()),
           "An attribute with the name '%s' already exists.", attribute.getName());