| commit | aeda58fce725d9304ac6f499a561fb776a31dd2e | [log] [tgz] |
|---|---|---|
| author | Googler <noreply@google.com> | Wed Sep 11 15:05:36 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Sep 11 15:07:10 2019 -0700 |
| tree | d8f187317b6874e20105e7b6ba62b9a48fe93038 | |
| parent | 9ce145a34d5dd246ce370ce3c3c0994d3155324d [diff] |
bazel syntax: make Parser private
Parser:
- Make it private. Call Expression.parse or BuildFileAST.parse.
(Statement.parse is only temporary.)
- Make all parser functions accept a ParserInputSource.
- Add ParserInputSource.fromLines helper, and many calls to it.
- Delete ParsingLevel. The checks for "if", "for", and "load" at
top-level belong in the validator, which knows what level it is at.
ValidationEnvironment:
- Move checkBuildSyntax to PackageFactory,
as it is a BUILD-ism. Callers must call validateFile
followed by PackageFactory.checkBuildSyntax.
- Move boundIdentifiers to Identifier.
- Surface isBuildFile parameter in all relevant APIs,
so that clients can tell which behavior they get.
We can't get rid of it until we rethink the way the prelude is implemented.
- ValidationEnvironment is now almost private, and will be made so in a follow-up.
BuildFileAST:
- Merge redundant parse{Build,Skylark}File functions. Now just parse().
- Rename remaining parse overloads to avoid ambiguity: parse{,WithDigest,WithImports}.
- Delete checkSyntax helper; call file.containsErrors() instead.
This modest change took 3.5 days' solid work.
It adds a lot of TODOs for next steps.
It is tempting to roll them all into this CL,
but doing that cost me the first day. :(
It's already complex enough. For now, baby steps.
PiperOrigin-RevId: 268551556
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.