Omit redundant 'Error in fail:' prefix from Starlark fail() error messages.
Calling `fail()` in Starlark previously formatted the final error line with `Error in fail: <message>` because `fail` is a builtin function and stack trace formatting prepended `Error in <builtin>: `. Because `fail()` is the standard mechanism in Starlark for rules, macros, and extensions to raise user-facing errors (such as invalid attribute values or unsupported targets), this prefix was redundant and made user errors look like internal failures within the `fail` function itself.
Format leaf `fail()` errors using the standard `Error: ` prefix, while preserving `Error in <builtin>: ` for other builtin functions (such as `getattr()`, `struct()`, or `dict()`).
For example, when a rule implementation calls `fail("unsupported platform: %s" % ctx.attr.platform)`:
Before:
```
Traceback (most recent call last):
File "/workspace/pkg/rules.bzl", line 5, column 9, in _impl
fail("unsupported platform: %s" % ctx.attr.platform)
Error in fail: unsupported platform: foo
```
After:
```
Traceback (most recent call last):
File "/workspace/pkg/rules.bzl", line 5, column 9, in _impl
fail("unsupported platform: %s" % ctx.attr.platform)
Error: unsupported platform: foo
```
RELNOTES: Starlark `fail()` calls now format error messages with `Error: ` instead of `Error in fail: `.
Resolves https://github.com/bazelbuild/bazel/issues/21523.
PiperOrigin-RevId: 971759352
Change-Id: Idda5352f05c8d7c297261ca65e4d2906369513a8
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md