commit b089102475ec95f83b477232e221d99a558a77b7
author Googler <jingwen@google.com> Tue Jun 18 05:55:58 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jun 18 05:57:17 2024 -0700
tree a5c8f63b55ad7829093a3332e97e7270654b12af
parent 9368c6020b59dd808c64a2f979ed42cf3ca4c76c

Improve error message when a node with a hermetic function is marked changed.

PiperOrigin-RevId: 644354056
Change-Id: Ia5cc843b75d781b248ac708e7200fcd810e18e5c

src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
index 51aa4e7..78bbcb9 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
@@ -482,7 +482,9 @@
         if (setToCheck.add(key)) {
           Preconditions.checkState(
               !isChanged || key.functionName().getHermeticity() != FunctionHermeticity.HERMETIC,
-              key);
+              "Nodes with hermetic functions cannot be marked 'changed': "
+                  + "%s function:%s hermeticity:%s"
+                      .formatted(key, key.functionName(), key.functionName().getHermeticity()));
           keysToGet.add(key);
         }
       }