commit b1f3302d93b05221ae7b6a50665a9765584b9edd
author Kush Chakraborty <kush@google.com> Wed Feb 08 17:35:02 2017 +0000
committer Kristina Chodorow <kchodorow@google.com> Wed Feb 08 17:51:08 2017 +0000
tree 4fde266868dae00e1ae9ac1594907144aece539b
parent 777f3afea4195e094d45bdfc317b236146117ff7

Make bazel test suites fail without a real test, by no longer adding an empty test in the TestSuiteBuilder. 

The current scenario can be bug-prone since changes to the TestSuiteBuilder code may bypass all tests, and in the absence of test failures, our tests will signal success.

RELNOTES: Make it mandatory for Java test suites in bazel codebase, to contain at least one test.

--
PiperOrigin-RevId: 146919833
MOS_MIGRATED_REVID=146919833

src/test/java/com/google/devtools/build/lib/AllTests.java

diff --git a/src/test/java/com/google/devtools/build/lib/AllTests.java b/src/test/java/com/google/devtools/build/lib/AllTests.java
index 78d6cc8..d3c745d 100644
--- a/src/test/java/com/google/devtools/build/lib/AllTests.java
+++ b/src/test/java/com/google/devtools/build/lib/AllTests.java
@@ -13,7 +13,7 @@
 // limitations under the License.
 package com.google.devtools.build.lib;
 
-import com.google.devtools.build.lib.testutil.BlazeTestSuiteBuilder;
+import com.google.devtools.build.lib.testutil.BazelTestSuiteBuilder;
 import com.google.devtools.build.lib.testutil.CustomSuite;
 
 import org.junit.runner.RunWith;
@@ -24,11 +24,11 @@
  * General test suite with defaults suitable for most of our tests.
  */
 @RunWith(CustomSuite.class)
-public class AllTests extends BlazeTestSuiteBuilder {
+public class AllTests extends BazelTestSuiteBuilder {
   public static Set<Class<?>> suite() {
     return new AllTests()
         .getBuilder()
-        .matchClasses(BlazeTestSuiteBuilder.TEST_SUPPORTS_CURRENT_OS)
+        .matchClasses(BazelTestSuiteBuilder.TEST_SUPPORTS_CURRENT_OS)
         .create();
   }
 }