commit b22c7ee8ae8f7403a0e2b7e8f9a7ade4d5979429
author ulfjack <ulfjack@google.com> Mon May 14 05:32:03 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon May 14 05:34:31 2018 -0700
tree d71f4fb1d74fc248722068f486e07bad8670a1d7
parent c4fc6201fdfa71993e2e9e295a946150e6990c75

Refactor TestAttempt event posting code

For flaky tests, Bazel may have cached information about multiple test attempts. In that case, we might want to post all of them on a subsequent cache hit, rather than posting only the passing attempt.

We currently subclass TestResult inside Google, which overrides the new getCachedTestAttempts method.

PiperOrigin-RevId: 196491575

src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java

diff --git a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
index c1248a6..91d8297 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
@@ -165,7 +165,7 @@
       actionExecutionContext
           .getEventHandler()
           .post(
-              new TestAttempt(
+              TestAttempt.forExecutedTestResult(
                   action,
                   standaloneTestResult.executionInfo(),
                   attempt,
@@ -242,7 +242,7 @@
     actionExecutionContext
         .getEventHandler()
         .post(
-            new TestAttempt(
+            TestAttempt.forExecutedTestResult(
                 action,
                 result.executionInfo(),
                 attempt,