| commit | b50cbd5322307825cae6fa915035a183f53195c1 | [log] [tgz] |
|---|---|---|
| author | leba <leba@google.com> | Tue Apr 26 08:38:27 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Apr 26 08:39:53 2022 -0700 |
| tree | 62d29555cc984dd186302b1bdfbf939619f28a71 | |
| parent | 91f842130769c9123f77f6948757ef778ca6f4a4 [diff] |
Remove `addAll` for always-empty set. If exceptionInducingTargets isn't empty, an error would have been thrown and we wouldn't have reached this return line anyway. PiperOrigin-RevId: 444569174
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/constraints/TopLevelConstraintSemantics.java b/src/main/java/com/google/devtools/build/lib/analysis/constraints/TopLevelConstraintSemantics.java index 6b11133..efdff8c 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/constraints/TopLevelConstraintSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/constraints/TopLevelConstraintSemantics.java
@@ -309,7 +309,7 @@ .setAnalysis(Analysis.newBuilder().setCode(Code.TARGETS_MISSING_ENVIRONMENTS)) .build()); } - return ImmutableSet.copyOf(badTargets.addAll(exceptionInducingTargets.keySet()).build()); + return badTargets.build(); } /**