commit b51251ed0df121b50fba315d4eee17fa40049e83
author Michael Staib <mstaib@google.com> Tue Sep 29 23:31:51 2015 +0000
committer Florian Weikert <fwe@google.com> Wed Sep 30 09:36:25 2015 +0000
tree d36907ff0df148711168c8cfaa8cc2eb43201f61
parent 5fb1073d31e392e2f39a067647337043500b348e

Extract configuration fragment access logic into ConfigurationFragmentPolicy.

This is the first step toward giving aspects the ability to define their own
required configuration fragments, extracting the required configuration
metadata into a common place.

This should be a no-op refactoring.

--
MOS_MIGRATED_REVID=104249500

src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java
index 06e068d..8053543 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java
@@ -26,6 +26,7 @@
 import com.google.devtools.build.lib.events.EventHandler;
 import com.google.devtools.build.lib.packages.AspectDefinition;
 import com.google.devtools.build.lib.packages.Attribute;
+import com.google.devtools.build.lib.packages.ConfigurationFragmentPolicy;
 import com.google.devtools.build.lib.packages.NoSuchPackageException;
 import com.google.devtools.build.lib.packages.NoSuchTargetException;
 import com.google.devtools.build.lib.packages.NoSuchThingException;
@@ -136,8 +137,10 @@
 
     // Get configuration fragments directly required by this target.
     if (target instanceof Rule) {
+      ConfigurationFragmentPolicy configurationFragmentPolicy =
+          target.getAssociatedRule().getRuleClassObject().getConfigurationFragmentPolicy();
       Set<Class<?>> configFragments =
-          target.getAssociatedRule().getRuleClassObject().getRequiredConfigurationFragments();
+          configurationFragmentPolicy.getRequiredConfigurationFragments();
       // An empty result means this rule requires all fragments (which practically means
       // the rule isn't yet declaring its actually needed fragments). So load everything.
       configFragments = configFragments.isEmpty() ? getAllFragments() : configFragments;