commit b5a06f3362b430d0f51d1f4da646f2de901e5707
author Ulf Adams <ulfjack@google.com> Tue Jun 21 14:55:49 2016 +0000
committer Philipp Wollermann <philwo@google.com> Tue Jun 21 15:04:38 2016 +0000
tree 2c9023bdf2338fcc4a262026783d8fcbc3800281
parent bfffc5075e23b0e2721bdf9487950d656daad0a2

Pass a locale to a getLowerCase call in BlazeRuntime.

Behavior of getLowerCase/getUpperCase is locale-specific, and can be rather
surprising. We should _always_ pass a locale explicitly.

--
MOS_MIGRATED_REVID=125450790

src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java

diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java
index 4e9de80..0a922fc 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java
@@ -114,6 +114,7 @@
 import java.util.Iterator;
 import java.util.LinkedHashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
@@ -988,7 +989,7 @@
     }
 
     BlazeServerStartupOptions startupOptions = options.getOptions(BlazeServerStartupOptions.class);
-    String productName = startupOptions.productName.toLowerCase();
+    String productName = startupOptions.productName.toLowerCase(Locale.US);
 
     if (startupOptions.oomMoreEagerlyThreshold != 100) {
       new RetainedHeapLimiter(startupOptions.oomMoreEagerlyThreshold).install();