commit b639ca82115765c59555410210fb00c484a3bc4d
author Laurent Le Brun <laurentlb@google.com> Tue Jan 17 11:18:23 2017 +0000
committer Vladimir Moskva <vladmos@google.com> Tue Jan 17 12:16:14 2017 +0000
tree 54fe20bb0c794edd958e11e8b9f59501095bd1bd
parent c0be64464b97ea011b4b4ad901515aac1dc97b4c

Require parens around tuple with trailing comma.

RELNOTES[INC]:
  Tuples that end with a trailing comma must now be inside parens,
  e.g. (1,) instead of 1,

--
PiperOrigin-RevId: 144690953
MOS_MIGRATED_REVID=144690953

src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java b/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
index c527fd2..43f6bcf 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
@@ -555,8 +555,19 @@
   }
 
   @Test
-  public void testTupleWithoutParensWithTrailingComma() throws Exception {
-    ListLiteral tuple = (ListLiteral) parseExpression("0, 1, 2, 3,");
+  public void testTupleWithTrailingComma() throws Exception {
+    setFailFast(false);
+
+    // Unlike Python, we require parens here.
+    parseExpression("0, 1, 2, 3,");
+    assertContainsError("Trailing comma");
+    clearEvents();
+
+    parseExpression("1 + 2,");
+    assertContainsError("Trailing comma");
+    clearEvents();
+
+    ListLiteral tuple = (ListLiteral) parseExpression("(0, 1, 2, 3,)");
     assertTrue(tuple.isTuple());
     assertThat(tuple.getElements()).hasSize(4);
     assertTrue(tuple.isTuple());