commit b808db4d19e4114bc5e265f4be6b6b2f32e2fa68
author Googler <noreply@google.com> Tue May 14 16:32:30 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue May 14 16:33:43 2019 -0700
tree 1d4790e77a338bb6b4b9979fd47fbfaee7e1b6d0
parent 586e6602b8a3868f73aff08db2be582fc0b834ba

Create a method to get the number of dep groups without getting all of the deps.

Saves a little bit of work/garbage during dirtiness checking.

RELNOTES: None.
PiperOrigin-RevId: 248234965

src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
index 81e9dc6..408b448 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -207,12 +207,17 @@
   }
 
   @Override
-  public synchronized Iterable<SkyKey> getDirectDeps() {
+  public Iterable<SkyKey> getDirectDeps() {
     return GroupedList.compressedToIterable(getCompressedDirectDepsForDoneEntry());
   }
 
+  @Override
+  public int getNumberOfDirectDepGroups() {
+    return GroupedList.numGroups(getCompressedDirectDepsForDoneEntry());
+  }
+
   /** Returns the compressed {@link GroupedList} of direct deps. Can only be called when done. */
-  public synchronized @GroupedList.Compressed Object getCompressedDirectDepsForDoneEntry() {
+  public final synchronized @GroupedList.Compressed Object getCompressedDirectDepsForDoneEntry() {
     assertKeepDeps();
     Preconditions.checkState(isDone(), "no deps until done. NodeEntry: %s", this);
     Preconditions.checkNotNull(directDeps, "deps can't be null: %s", this);