commit b81776fad62771a261eaa8ec8ecedca3bd88969a
author nharmata <nharmata@google.com> Mon Feb 25 15:52:33 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Feb 25 15:54:16 2019 -0800
tree 93167f2c1c4a5faea271b3927d0db5994b67cc44
parent 4c8c152da4a5dee33c26154379486689df6e3035

Properly presize the HashMap in
Attribute#ComputationStrategy.computeValuesForAllCombinations.

This helper method is used by Rule#getTransitions and so is used in transitive
target visitation.

RELNOTES: None
PiperOrigin-RevId: 235617961

src/main/java/com/google/devtools/build/lib/packages/Attribute.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Attribute.java b/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
index 83f4914..ceb3e9a 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
@@ -26,6 +26,7 @@
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Iterables;
+import com.google.common.collect.Maps;
 import com.google.common.collect.Ordering;
 import com.google.common.collect.Sets;
 import com.google.devtools.build.lib.analysis.TransitiveInfoProvider;
@@ -1312,7 +1313,7 @@
       List<Map<String, Object>> depMaps = mapper.visitAttributes(dependencies, limiter);
       // For each combination, call compute() on a specialized AttributeMap providing those
       // values.
-      Map<List<Object>, T> valueMap = new HashMap<>(depMaps.size());
+      Map<List<Object>, T> valueMap = Maps.newHashMapWithExpectedSize(depMaps.size());
       for (Map<String, Object> depMap : depMaps) {
         AttributeMap attrMap = mapper.createMapBackedAttributeMap(depMap);
         Object value = compute(attrMap);