Add support for rules_test on rules in a different repository or in the
root package.
--
Change-Id: Ibbc4119ec65c27ad1f85a74450815195d18f5128
Reviewed-on: https://cr.bazel.build/7571
MOS_MIGRATED_REVID=140625048
diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD
index 851dec5..78f8613 100644
--- a/src/test/shell/bazel/BUILD
+++ b/src/test/shell/bazel/BUILD
@@ -417,6 +417,14 @@
tags = ["manual"],
)
+sh_test(
+ name = "rule_test_test",
+ size = "medium",
+ srcs = ["rule_test_test.sh"],
+ data = [":test-deps"],
+ shard_count = 2,
+)
+
test_suite(
name = "all_tests",
visibility = ["//visibility:public"],
diff --git a/src/test/shell/bazel/rule_test_test.sh b/src/test/shell/bazel/rule_test_test.sh
new file mode 100755
index 0000000..09c0add
--- /dev/null
+++ b/src/test/shell/bazel/rule_test_test.sh
@@ -0,0 +1,153 @@
+#!/bin/bash
+#
+# Copyright 2016 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# Test rule_test usage.
+#
+
+# Load the test setup defined in the parent directory
+CURRENT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+source "${CURRENT_DIR}/../integration_test_setup.sh" \
+ || { echo "integration_test_setup.sh not found!" >&2; exit 1; }
+
+function test_local_rule_test_in_root() {
+ create_new_workspace
+ cat > BUILD <<EOF
+genrule(
+ name = "turtle",
+ outs = ["tmnt"],
+ cmd = "echo 'Leonardo' > \$@",
+ visibility = ["//visibility:public"],
+)
+
+load(
+ "@bazel_tools//tools/build_rules:test_rules.bzl",
+ "rule_test",
+)
+
+rule_test(
+ name="turtle_rule_test",
+ rule="//:turtle",
+ generates=[
+ "tmnt",
+ ],
+)
+EOF
+
+ bazel build //:turtle_rule_test &> $TEST_log || fail "turtle_rule_test failed"
+}
+
+function test_local_rule_test_in_subpackage() {
+ create_new_workspace
+ mkdir p
+ cat > p/BUILD <<EOF
+genrule(
+ name = "turtle",
+ outs = ["tmnt"],
+ cmd = "echo 'Leonardo' > \$@",
+ visibility = ["//visibility:public"],
+)
+
+load(
+ "@bazel_tools//tools/build_rules:test_rules.bzl",
+ "rule_test",
+)
+
+rule_test(
+ name="turtle_rule_test",
+ rule="//p:turtle",
+ generates=[
+ "tmnt",
+ ],
+)
+EOF
+
+ bazel build //p:turtle_rule_test &> $TEST_log || fail "turtle_rule_test failed"
+}
+
+function test_repository_rule_test_in_root() {
+ create_new_workspace
+ mkdir -p r
+
+ cat >> WORKSPACE <<EOF
+local_repository(name = "r", path = "r")
+EOF
+ cat > r/WORKSPACE <<EOF
+workspace(name = "r")
+EOF
+ cat > r/BUILD <<EOF
+genrule(
+ name = "turtle",
+ outs = ["tmnt"],
+ cmd = "echo 'Leonardo' > \$@",
+ visibility = ["//visibility:public"],
+)
+EOF
+ cat > BUILD <<EOF
+load(
+ "@bazel_tools//tools/build_rules:test_rules.bzl",
+ "rule_test",
+)
+
+rule_test(
+ name="turtle_rule_test",
+ rule="@r//:turtle",
+ generates=[
+ "tmnt",
+ ],
+)
+EOF
+
+ bazel build //:turtle_rule_test &> $TEST_log || fail "turtle_rule_test failed"
+}
+
+function test_repository_rule_test_in_subpackage() {
+ create_new_workspace
+ mkdir -p r
+
+ cat >> WORKSPACE <<EOF
+local_repository(name = "r", path = "r")
+EOF
+ cat > r/WORKSPACE <<EOF
+workspace(name = "r")
+EOF
+ mkdir r/p
+ cat > r/p/BUILD <<EOF
+genrule(
+ name = "turtle",
+ outs = ["tmnt"],
+ cmd = "echo 'Leonardo' > \$@",
+ visibility = ["//visibility:public"],
+)
+EOF
+ cat > BUILD <<EOF
+load(
+ "@bazel_tools//tools/build_rules:test_rules.bzl",
+ "rule_test",
+)
+
+rule_test(
+ name="turtle_rule_test",
+ rule="@r//p:turtle",
+ generates=[
+ "tmnt",
+ ],
+)
+EOF
+
+ bazel build //:turtle_rule_test &> $TEST_log || fail "turtle_rule_test failed"
+}
+
+run_suite "rule_test tests"
diff --git a/tools/build_rules/test_rules.bzl b/tools/build_rules/test_rules.bzl
index a9b9d2d..02fcf32 100644
--- a/tools/build_rules/test_rules.bzl
+++ b/tools/build_rules/test_rules.bzl
@@ -184,9 +184,26 @@
rule_name = str(rule_.label)
exe = ctx.outputs.executable
if ctx.attr.generates:
- prefix = rule_.label.package + "/"
+ # Generate the proper prefix to remove from generated files.
+ prefix_parts = []
+
+ if rule_.label.workspace_root:
+ # Create a prefix that is correctly relative to the output of this rule.
+ prefix_parts = ["..", strip_prefix("external/", rule_.label.workspace_root)]
+
+ if rule_.label.package:
+ prefix_parts.append(rule_.label.package)
+
+ prefix = "/".join(prefix_parts)
+
+ if prefix:
+ # If the prefix isn't empty, it needs a trailing slash.
+ prefix = prefix + "/"
+
# TODO(bazel-team): Use set() instead of sorted() once
# set comparison is implemented.
+ # TODO(bazel-team): Use a better way to determine if two paths refer to
+ # the same file.
generates = sorted(ctx.attr.generates)
generated = sorted([strip_prefix(prefix, f.short_path)
for f in rule_.files])
