Add functionality to make certain SkyValues unshareable, meaning they are not serialized. Tag TestCompletionValue and any ActionExecutionValue coming from a NotifyOnActionCacheHit (i.e., tests) like that. To make such values really not shared, request the ActionExecutionValue from TestCompletionFunction as opposed to the ArtifactValue (propagating the unshareable bit up seemed like too much fuss, and I have a dream of getting rid of ArtifactValue anyway).
PiperOrigin-RevId: 200504358
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/ArtifactFunctionTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/ArtifactFunctionTest.java
index 8a22813..da66c93 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/ArtifactFunctionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/ArtifactFunctionTest.java
@@ -426,8 +426,12 @@
} catch (IOException e) {
throw new IllegalStateException(e);
}
- return new ActionExecutionValue(
- artifactData, treeArtifactData, additionalOutputData, /*outputSymlinks=*/ null);
+ return ActionExecutionValue.create(
+ artifactData,
+ treeArtifactData,
+ additionalOutputData,
+ /*outputSymlinks=*/ null,
+ /*notifyOnActionCacheHitAction=*/ false);
}
@Override
