commit badc2c5a40b0dcef181dc29a3d11621dd5ff00fd
author janakr <janakr@google.com> Mon Dec 20 10:37:01 2021 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Dec 20 10:38:26 2021 -0800
tree 3029f2cd3b9a15c937dcbb8d3d675f5b0bb4a353
parent e3a37b5ef1d52276db7c5a38d45cd3e154c7cf48

Add method to SkyframeExecutor to get node value intra-evaluation, only for internal use. Also some minor clean-ups.

PiperOrigin-RevId: 417435604

src/main/java/com/google/devtools/build/lib/skyframe/ActionTemplateExpansionValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ActionTemplateExpansionValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/ActionTemplateExpansionValue.java
index 514236a..6f83aab 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ActionTemplateExpansionValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ActionTemplateExpansionValue.java
@@ -13,6 +13,7 @@
 // limitations under the License.
 package com.google.devtools.build.lib.skyframe;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.Interner;
 import com.google.devtools.build.lib.actions.ActionLookupKey;
@@ -23,9 +24,7 @@
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
 import com.google.devtools.build.skyframe.SkyFunctionName;
 
-/**
- * Value that stores expanded actions from ActionTemplate.
- */
+/** Value that stores expanded actions from ActionTemplate. */
 public final class ActionTemplateExpansionValue extends BasicActionLookupValue {
   ActionTemplateExpansionValue(GeneratingActions generatingActions) {
     super(generatingActions);
@@ -49,9 +48,9 @@
       this.actionIndex = actionIndex;
     }
 
-    @AutoCodec.VisibleForSerialization
+    @VisibleForTesting
     @AutoCodec.Instantiator
-    static ActionTemplateExpansionKey of(ActionLookupKey actionLookupKey, int actionIndex) {
+    public static ActionTemplateExpansionKey of(ActionLookupKey actionLookupKey, int actionIndex) {
       return interner.intern(new ActionTemplateExpansionKey(actionLookupKey, actionIndex));
     }