commit baeba8b286f9fef8c5a0dcd55086855626f27735
author Googler <noreply@google.com> Wed Apr 20 19:20:37 2016 +0000
committer Damien Martin-Guillerez <dmarting@google.com> Thu Apr 21 10:59:33 2016 +0000
tree fb3a066c0dcdfa9ff41e289453a89670ed5ee01c
parent 31a4a1f4c413a2bd88fe40593e3dc8f4a5b41bda

Short-circuit Path.equals() with hashcode.

Optimize .equals() by using the hashcode calculated in the constructor to determine if we can short-circuit equals and avoid traversing the parents if the two paths can't be equal.

--
MOS_MIGRATED_REVID=120363376

src/main/java/com/google/devtools/build/lib/vfs/Path.java

diff --git a/src/main/java/com/google/devtools/build/lib/vfs/Path.java b/src/main/java/com/google/devtools/build/lib/vfs/Path.java
index e20247d..ffd41d2 100644
--- a/src/main/java/com/google/devtools/build/lib/vfs/Path.java
+++ b/src/main/java/com/google/devtools/build/lib/vfs/Path.java
@@ -345,6 +345,9 @@
       return false;
     }
     Path otherPath = (Path) other;
+    if (hashCode != otherPath.hashCode) {
+      return false;
+    }
     return fileSystem.equals(otherPath.fileSystem) && name.equals(otherPath.name)
         && Objects.equals(parent, otherPath.parent);
   }