Rename `--experimental_remote_grpc_log` to `--remote_grpc_log` (#18193)
GRPC logging has been in use since the start of REAPI application to bazel, and is sufficiently stable and supported by tools_remote/remote_client
RELNOTES: `--experimental_remote_grpc_log` has been renamed to `--remote_grpc_log`
Closes #18180.
PiperOrigin-RevId: 526633832
Change-Id: Ib3b06c303f39f1dd8e1eff3b5b4d4d146f148665
Co-authored-by: George Gensure <werkt0@gmail.com>
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java
index bd0f63c..417ec5b 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java
@@ -379,11 +379,11 @@
}
ClientInterceptor loggingInterceptor = null;
- if (remoteOptions.experimentalRemoteGrpcLog != null) {
+ if (remoteOptions.remoteGrpcLog != null) {
try {
rpcLogFile =
new AsynchronousFileOutputStream(
- env.getWorkingDirectory().getRelative(remoteOptions.experimentalRemoteGrpcLog));
+ env.getWorkingDirectory().getRelative(remoteOptions.remoteGrpcLog));
} catch (IOException e) {
handleInitFailure(env, e, Code.RPC_LOG_FAILURE);
return;
diff --git a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
index 893523a..4eeacdb 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
@@ -397,7 +397,8 @@
public boolean experimentalGuardAgainstConcurrentChanges;
@Option(
- name = "experimental_remote_grpc_log",
+ name = "remote_grpc_log",
+ oldName = "experimental_remote_grpc_log",
defaultValue = "null",
category = "remote",
documentationCategory = OptionDocumentationCategory.REMOTE,
@@ -410,7 +411,7 @@
+ "protobufs with each message prefixed by a varint denoting the size of the"
+ " following serialized protobuf message, as performed by the method "
+ "LogEntry.writeDelimitedTo(OutputStream).")
- public PathFragment experimentalRemoteGrpcLog;
+ public PathFragment remoteGrpcLog;
@Option(
name = "incompatible_remote_symlinks",
