commit bb3989bfe2f3bc824d4c3cddd044db91d6d19662
author mjhalupka <mjhalupka@google.com> Tue Jan 08 14:10:49 2019 -0800
committer Copybara-Service <copybara-piper@google.com> Tue Jan 08 14:12:32 2019 -0800
tree 878edc4bc8444337a7babb572cf8529c9b6967cf
parent 8685eafcabe2e11095b6848f373c37eb1b5d24b4

Make AST_FILE_LOOKUP and EXTERNAL_PACKAGE hermetic.

PiperOrigin-RevId: 228396917

src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
index 0e726e5..1db84bb 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
@@ -44,9 +44,8 @@
       SkyFunctionName.createHermetic("PACKAGE_LOOKUP");
   public static final SkyFunctionName CONTAINING_PACKAGE_LOOKUP =
       SkyFunctionName.createHermetic("CONTAINING_PACKAGE_LOOKUP");
-  // Non-hermetic because accesses the package locator. Also does disk access.
   public static final SkyFunctionName AST_FILE_LOOKUP =
-      SkyFunctionName.createNonHermetic("AST_FILE_LOOKUP");
+      SkyFunctionName.createHermetic("AST_FILE_LOOKUP");
   public static final SkyFunctionName SKYLARK_IMPORTS_LOOKUP =
       SkyFunctionName.createHermetic("SKYLARK_IMPORTS_LOOKUP");
   public static final SkyFunctionName GLOB = SkyFunctionName.createHermetic("GLOB");
@@ -126,9 +125,8 @@
       SkyFunctionName.createNonHermetic("REPOSITORY_DIRECTORY");
   public static final SkyFunctionName WORKSPACE_AST =
       SkyFunctionName.createHermetic("WORKSPACE_AST");
-  // Non-hermetic because accesses package locator
   public static final SkyFunctionName EXTERNAL_PACKAGE =
-      SkyFunctionName.createNonHermetic("EXTERNAL_PACKAGE");
+      SkyFunctionName.createHermetic("EXTERNAL_PACKAGE");
   public static final SkyFunctionName ACTION_TEMPLATE_EXPANSION =
       SkyFunctionName.createHermetic("ACTION_TEMPLATE_EXPANSION");
   public static final SkyFunctionName LOCAL_REPOSITORY_LOOKUP =