commit bfbd95f3a5a8f928fd477c3d875ac62ec3d40dcc
author jmmv <jmmv@google.com> Mon Aug 31 13:12:38 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 31 13:14:12 2020 -0700
tree da0222bad2872d628a0d641e063755c8c587c91f
parent 98bdf371d67e8832b0549beb0c3ba1261270f0c0

Fix multi-word test case names to use lowerCamelCase.

This is to follow the style guide recommendation in:
https://google.github.io/styleguide/javaguide.html#s5.2.3-method-names
and to fix lint warnings that have already gotten in the way of two
of my recent CLs.

This change was automatically generated by collecting the list of all
affected files in a "list" file and doing:

for f in $(cat /tmp/list); do
  sed -itmp -e '/void test.*_[A-Z]/s/\(_[A-Z]\)/\L\1/g' "$f"
done

... and then skimming through the diff to undo a few "fixes" that were
incorrect because we have test names encoding literals like "BUILD".

PiperOrigin-RevId: 329363594

src/test/java/com/google/devtools/build/lib/runtime/CommandLineEventTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/runtime/CommandLineEventTest.java b/src/test/java/com/google/devtools/build/lib/runtime/CommandLineEventTest.java
index 944aa36..61f7d7b 100644
--- a/src/test/java/com/google/devtools/build/lib/runtime/CommandLineEventTest.java
+++ b/src/test/java/com/google/devtools/build/lib/runtime/CommandLineEventTest.java
@@ -52,7 +52,7 @@
   }
 
   @Test
-  public void testMostlyEmpty_OriginalCommandLine() {
+  public void testMostlyEmpty_originalCommandLine() {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
     OptionsParser fakeCommandOptions =
@@ -79,7 +79,7 @@
   }
 
   @Test
-  public void testMostlyEmpty_CanonicalCommandLine() {
+  public void testMostlyEmpty_canonicalCommandLine() {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
     OptionsParser fakeCommandOptions =
@@ -105,7 +105,7 @@
   }
 
   @Test
-  public void testActiveBazelrcs_OriginalCommandLine() throws OptionsParsingException {
+  public void testActiveBazelrcs_originalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder()
             .optionsClasses(BlazeServerStartupOptions.class, Options.class)
@@ -144,7 +144,7 @@
   }
 
   @Test
-  public void testPassedInBazelrcs_OriginalCommandLine() throws OptionsParsingException {
+  public void testPassedInBazelrcs_originalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder()
             .optionsClasses(BlazeServerStartupOptions.class, Options.class)
@@ -188,7 +188,7 @@
   }
 
   @Test
-  public void testBazelrcs_CanonicalCommandLine() throws OptionsParsingException {
+  public void testBazelrcs_canonicalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder()
             .optionsClasses(BlazeServerStartupOptions.class, Options.class)
@@ -220,7 +220,7 @@
   }
 
   @Test
-  public void testOptionsAtVariousPriorities_OriginalCommandLine() throws OptionsParsingException {
+  public void testOptionsAtVariousPriorities_originalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
     OptionsParser fakeCommandOptions =
@@ -264,7 +264,7 @@
   }
 
   @Test
-  public void testOptionsAtVariousPriorities_CanonicalCommandLine() throws OptionsParsingException {
+  public void testOptionsAtVariousPriorities_canonicalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
     OptionsParser fakeCommandOptions =
@@ -307,7 +307,7 @@
   }
 
   @Test
-  public void testExpansionOption_OriginalCommandLine() throws OptionsParsingException {
+  public void testExpansionOption_originalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
     OptionsParser fakeCommandOptions =
@@ -340,7 +340,7 @@
   }
 
   @Test
-  public void testExpansionOption_CanonicalCommandLine() throws OptionsParsingException {
+  public void testExpansionOption_canonicalCommandLine() throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
     OptionsParser fakeCommandOptions =
@@ -375,7 +375,7 @@
   }
 
   @Test
-  public void testOptionWithImplicitRequirement_OriginalCommandLine()
+  public void testOptionWithImplicitRequirement_originalCommandLine()
       throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();
@@ -410,7 +410,7 @@
   }
 
   @Test
-  public void testOptionWithImplicitRequirement_CanonicalCommandLine()
+  public void testOptionWithImplicitRequirement_canonicalCommandLine()
       throws OptionsParsingException {
     OptionsParser fakeStartupOptions =
         OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build();

src/test/java/com/google/devtools/build/lib/runtime/ProcessWrapperTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/runtime/ProcessWrapperTest.java b/src/test/java/com/google/devtools/build/lib/runtime/ProcessWrapperTest.java
index b509cbb..4f6b1a8 100644
--- a/src/test/java/com/google/devtools/build/lib/runtime/ProcessWrapperTest.java
+++ b/src/test/java/com/google/devtools/build/lib/runtime/ProcessWrapperTest.java
@@ -47,7 +47,7 @@
   }
 
   @Test
-  public void testProcessWrapperCommandLineBuilder_BuildsWithoutOptionalArguments()
+  public void testProcessWrapperCommandLineBuilder_buildsWithoutOptionalArguments()
       throws IOException {
     ImmutableList<String> commandArguments = ImmutableList.of("echo", "hello, world");
 
@@ -63,7 +63,7 @@
   }
 
   @Test
-  public void testProcessWrapperCommandLineBuilder_BuildsWithOptionalArguments()
+  public void testProcessWrapperCommandLineBuilder_buildsWithOptionalArguments()
       throws IOException {
     ImmutableList<String> extraFlags = ImmutableList.of("--debug");
     ImmutableList<String> commandArguments = ImmutableList.of("echo", "hello, world");