Fix multi-word test case names to use lowerCamelCase.
This is to follow the style guide recommendation in:
https://google.github.io/styleguide/javaguide.html#s5.2.3-method-names
and to fix lint warnings that have already gotten in the way of two
of my recent CLs.
This change was automatically generated by collecting the list of all
affected files in a "list" file and doing:
for f in $(cat /tmp/list); do
sed -itmp -e '/void test.*_[A-Z]/s/\(_[A-Z]\)/\L\1/g' "$f"
done
... and then skimming through the diff to undo a few "fixes" that were
incorrect because we have test names encoding literals like "BUILD".
PiperOrigin-RevId: 329363594
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/PackageFunctionTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/PackageFunctionTest.java
index e79f5d2..05157c5 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/PackageFunctionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/PackageFunctionTest.java
@@ -318,7 +318,7 @@
}
@Test
- public void testPropagatesFilesystemInconsistencies_Globbing() throws Exception {
+ public void testPropagatesFilesystemInconsistencies_globbing() throws Exception {
getSkyframeExecutor().turnOffSyscallCacheForTesting();
reporter.removeHandler(failFastHandler);
RecordingDifferencer differencer = getSkyframeExecutor().getDifferencerForTesting();
@@ -937,7 +937,7 @@
}
@Test
- public void testGlobAllowEmpty_ParamValueMustBeBoolean() throws Exception {
+ public void testGlobAllowEmpty_paramValueMustBeBoolean() throws Exception {
reporter.removeHandler(failFastHandler);
scratch.file("pkg/BUILD", "x = " + "glob(['*.foo'], allow_empty = 5)");
@@ -950,7 +950,7 @@
}
@Test
- public void testGlobAllowEmpty_FunctionParam() throws Exception {
+ public void testGlobAllowEmpty_functionParam() throws Exception {
scratch.file("pkg/BUILD", "x = " + "glob(['*.foo'], allow_empty=True)");
invalidatePackages();
@@ -961,7 +961,7 @@
}
@Test
- public void testGlobAllowEmpty_StarlarkOption() throws Exception {
+ public void testGlobAllowEmpty_starlarkOption() throws Exception {
preparePackageLoadingWithCustomStarklarkSemanticsOptions(
Options.parse(StarlarkSemanticsOptions.class, "--incompatible_disallow_empty_glob=false")
.getOptions(),
@@ -977,7 +977,7 @@
}
@Test
- public void testGlobDisallowEmpty_FunctionParam_WasNonEmptyAndBecomesEmpty() throws Exception {
+ public void testGlobDisallowEmpty_functionParam_wasNonEmptyAndBecomesEmpty() throws Exception {
scratch.file("pkg/BUILD", "x = " + "glob(['*.foo'], allow_empty=False)");
scratch.file("pkg/blah.foo");
invalidatePackages();
@@ -1004,7 +1004,7 @@
}
@Test
- public void testGlobDisallowEmpty_StarlarkOption_WasNonEmptyAndBecomesEmpty() throws Exception {
+ public void testGlobDisallowEmpty_starlarkOption_wasNonEmptyAndBecomesEmpty() throws Exception {
preparePackageLoadingWithCustomStarklarkSemanticsOptions(
Options.parse(StarlarkSemanticsOptions.class, "--incompatible_disallow_empty_glob=true")
.getOptions(),
@@ -1036,7 +1036,7 @@
}
@Test
- public void testGlobDisallowEmpty_FunctionParam_WasEmptyAndStaysEmpty() throws Exception {
+ public void testGlobDisallowEmpty_functionParam_wasEmptyAndStaysEmpty() throws Exception {
scratch.file("pkg/BUILD", "x = " + "glob(['*.foo'], allow_empty=False)");
invalidatePackages();
@@ -1063,7 +1063,7 @@
}
@Test
- public void testGlobDisallowEmpty_StarlarkOption_WasEmptyAndStaysEmpty() throws Exception {
+ public void testGlobDisallowEmpty_starlarkOption_wasEmptyAndStaysEmpty() throws Exception {
preparePackageLoadingWithCustomStarklarkSemanticsOptions(
Options.parse(StarlarkSemanticsOptions.class, "--incompatible_disallow_empty_glob=true")
.getOptions(),
@@ -1095,7 +1095,7 @@
}
@Test
- public void testGlobDisallowEmpty_FunctionParam_WasEmptyDueToExcludeAndStaysEmpty()
+ public void testGlobDisallowEmpty_functionParam_wasEmptyDueToExcludeAndStaysEmpty()
throws Exception {
scratch.file("pkg/BUILD", "x = glob(include=['*.foo'], exclude=['blah.*'], allow_empty=False)");
scratch.file("pkg/blah.foo");
@@ -1126,7 +1126,7 @@
}
@Test
- public void testGlobDisallowEmpty_StarlarkOption_WasEmptyDueToExcludeAndStaysEmpty()
+ public void testGlobDisallowEmpty_starlarkOption_wasEmptyDueToExcludeAndStaysEmpty()
throws Exception {
preparePackageLoadingWithCustomStarklarkSemanticsOptions(
Options.parse(StarlarkSemanticsOptions.class, "--incompatible_disallow_empty_glob=true")
@@ -1160,7 +1160,7 @@
}
@Test
- public void testGlobDisallowEmpty_FunctionParam_WasEmptyAndBecomesNonEmpty() throws Exception {
+ public void testGlobDisallowEmpty_functionParam_wasEmptyAndBecomesNonEmpty() throws Exception {
scratch.file("pkg/BUILD", "x = " + "glob(['*.foo'], allow_empty=False)");
invalidatePackages();
@@ -1188,7 +1188,7 @@
}
@Test
- public void testGlobDisallowEmpty_StarlarkOption_WasEmptyAndBecomesNonEmpty() throws Exception {
+ public void testGlobDisallowEmpty_starlarkOption_wasEmptyAndBecomesNonEmpty() throws Exception {
preparePackageLoadingWithCustomStarklarkSemanticsOptions(
Options.parse(StarlarkSemanticsOptions.class, "--incompatible_disallow_empty_glob=true")
.getOptions(),