commit c3bcb9838e17d08da0b7f30cbb0e4e284506748b
author janakr <janakr@google.com> Tue Apr 14 06:50:08 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 14 06:51:13 2020 -0700
tree 51890dd88a416d9ce62ed49cdc532deb98407be9
parent 36f8aba790a9a24f99870f781cf6dd08a5542b90

Migrating to fluent logging (green).

I did some minor clean-ups of the resulting logging statements (mostly moving/adding exceptions as causes that were missed), and a few other drive-bys.

PiperOrigin-RevId: 306429419

src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java

diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java
index 72c6d54..b47b728 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java
@@ -17,6 +17,7 @@
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableSet;
+import com.google.common.flogger.GoogleLogger;
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -41,8 +42,6 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.ExecutionException;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import javax.annotation.concurrent.GuardedBy;
 
 /**
@@ -53,7 +52,7 @@
  */
 class RemoteActionInputFetcher implements ActionInputPrefetcher {
 
-  private static final Logger logger = Logger.getLogger(RemoteActionInputFetcher.class.getName());
+  private static final GoogleLogger logger = GoogleLogger.forEnclosingClass();
 
   private final Object lock = new Object();
 
@@ -191,7 +190,7 @@
                   try {
                     path.chmod(0755);
                   } catch (IOException e) {
-                    logger.log(Level.WARNING, "Failed to chmod 755 on " + path, e);
+                    logger.atWarning().withCause(e).log("Failed to chmod 755 on %s", path);
                   }
                 }
 
@@ -203,10 +202,8 @@
                   try {
                     path.delete();
                   } catch (IOException e) {
-                    logger.log(
-                        Level.WARNING,
-                        "Failed to delete output file after incomplete download: " + path,
-                        e);
+                    logger.atWarning().withCause(e).log(
+                        "Failed to delete output file after incomplete download: %s", path);
                   }
                 }
               },