Migrating to fluent logging (green).
I did some minor clean-ups of the resulting logging statements (mostly moving/adding exceptions as causes that were missed), and a few other drive-bys.
PiperOrigin-RevId: 306429419
diff --git a/src/main/java/com/google/devtools/build/lib/server/IdleServerTasks.java b/src/main/java/com/google/devtools/build/lib/server/IdleServerTasks.java
index 82cb7b6..4d286e3 100644
--- a/src/main/java/com/google/devtools/build/lib/server/IdleServerTasks.java
+++ b/src/main/java/com/google/devtools/build/lib/server/IdleServerTasks.java
@@ -15,6 +15,7 @@
package com.google.devtools.build.lib.server;
import com.google.common.base.Preconditions;
+import com.google.common.flogger.GoogleLogger;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import com.google.devtools.build.lib.profiler.AutoProfiler;
import com.google.devtools.build.lib.profiler.GoogleAutoProfilerUtils;
@@ -25,7 +26,6 @@
import java.util.concurrent.Future;
import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
-import java.util.logging.Logger;
/**
* Run cleanup-related tasks during idle periods in the server.
@@ -33,7 +33,7 @@
*/
class IdleServerTasks {
private final ScheduledThreadPoolExecutor executor;
- private static final Logger logger = Logger.getLogger(IdleServerTasks.class.getName());
+ private static final GoogleLogger logger = GoogleLogger.forEnclosingClass();
/** Must be called from the main thread. */
public IdleServerTasks() {
@@ -59,13 +59,12 @@
System.gc();
}
MemoryUsage after = memBean.getHeapMemoryUsage();
- logger.info(
- String.format(
- "[Idle GC] used: %s -> %s, committed: %s -> %s",
- StringUtilities.prettyPrintBytes(before.getUsed()),
- StringUtilities.prettyPrintBytes(after.getUsed()),
- StringUtilities.prettyPrintBytes(before.getCommitted()),
- StringUtilities.prettyPrintBytes(after.getCommitted())));
+ logger.atInfo().log(
+ "[Idle GC] used: %s -> %s, committed: %s -> %s",
+ StringUtilities.prettyPrintBytes(before.getUsed()),
+ StringUtilities.prettyPrintBytes(after.getUsed()),
+ StringUtilities.prettyPrintBytes(before.getCommitted()),
+ StringUtilities.prettyPrintBytes(after.getCommitted()));
},
10,
TimeUnit.SECONDS);