commit c48214d69e893e3790b5ad0ac8bb316a4f942554
author Greg Estren <gregce@google.com> Tue Mar 17 22:43:19 2015 +0000
committer Kristina Chodorow <kchodorow@google.com> Wed Mar 18 13:47:56 2015 +0000
tree 18ff9d7735759482164dda95d0d8a45ef3fb7ec6
parent d0f10dc675d0faed892f135330dd7852d77b14bd

Remove "obsolete" and "default_obsolete" from the BUILD language.

Anyone who needs this kind of functionality in the future can redefine
it through user-defined constraints.

--
MOS_MIGRATED_REVID=88871811

src/main/java/com/google/devtools/build/lib/packages/Package.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Package.java b/src/main/java/com/google/devtools/build/lib/packages/Package.java
index b909dd8..fc2b379 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Package.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Package.java
@@ -133,11 +133,6 @@
   private boolean defaultVisibilitySet;
 
   /**
-   * Default package-level 'obsolete' value for rules that do not specify it.
-   */
-  private boolean defaultObsolete = false;
-
-  /**
    * Default package-level 'testonly' value for rules that do not specify it.
    */
   private boolean defaultTestOnly = false;
@@ -288,13 +283,6 @@
   }
 
   /**
-   * Set the default 'obsolete' value for this package.
-   */
-  protected void setDefaultObsolete(boolean obsolete) {
-    defaultObsolete = obsolete;
-  }
-
-  /**
    * Set the default 'testonly' value for this package.
    */
   protected void setDefaultTestOnly(boolean testOnly) {
@@ -646,13 +634,6 @@
   }
 
   /**
-   * Returns the default obsolete value.
-   */
-  public Boolean getDefaultObsolete() {
-    return defaultObsolete;
-  }
-
-  /**
    * Returns the default testonly value.
    */
   public Boolean getDefaultTestOnly() {
@@ -660,7 +641,7 @@
   }
 
   /**
-   * Returns the default obsolete value.
+   * Returns the default deprecation value.
    */
   public String getDefaultDeprecation() {
     return defaultDeprecation;
@@ -946,14 +927,6 @@
       return self();
     }
 
-    /**
-     * Sets the default value of 'obsolete'. Rule-level 'obsolete' will override this.
-     */
-    B setDefaultObsolete(boolean defaultObsolete) {
-      pkg.setDefaultObsolete(defaultObsolete);
-      return self();
-    }
-
     /** Sets the default value of 'testonly'. Rule-level 'testonly' will override this. */
     B setDefaultTestonly(boolean defaultTestonly) {
       pkg.setDefaultTestOnly(defaultTestonly);
@@ -1350,8 +1323,7 @@
       // time, as forward references are permitted.
       List<Label> allTests = new ArrayList<>();
       for (Rule rule : rules) {
-        if (TargetUtils.isTestRule(rule) && !TargetUtils.hasManualTag(rule)
-            && !TargetUtils.isObsolete(rule)) {
+        if (TargetUtils.isTestRule(rule) && !TargetUtils.hasManualTag(rule)) {
           allTests.add(rule.getLabel());
         }
       }