Get rid of stale TODO wrt order of logging options warnings
IIUC, at some point in the past we'd not log anything until --client_debug
was known. This was fixed so that any user and above (including warning)
messages were always emitted, and the other debug stuff is buffered and saved
until the level is known.
TESTED=Compiled w/ this change and confirmed options warnings showed up.
RELNOTES: None
PiperOrigin-RevId: 253259430
diff --git a/src/main/cpp/blaze.cc b/src/main/cpp/blaze.cc
index 308a671..2b128d4 100644
--- a/src/main/cpp/blaze.cc
+++ b/src/main/cpp/blaze.cc
@@ -1541,16 +1541,12 @@
const string workspace = workspace_layout->GetWorkspace(cwd);
ParseOptionsOrDie(cwd, workspace, *option_processor, argc, argv);
StartupOptions *startup_options = option_processor->GetParsedStartupOptions();
+ startup_options->MaybeLogStartupOptionWarnings();
SetDebugLog(startup_options->client_debug);
// If client_debug was false, this is ignored, so it's accurate.
BAZEL_LOG(INFO) << "Debug logging requested, sending all client log "
"statements to stderr";
- // TODO(b/79206210): Can't log this before SetDebugLog is called, since the
- // warning might get swallowed. Once the bug is fixed, move this call to
- // OptionProcessor::ParseOptionsOrDie where the order of operations is more
- // clear.
- startup_options->MaybeLogStartupOptionWarnings();
if (startup_options->unlimit_coredumps) {
UnlimitCoredumps();
