Refactor compute codepath in StarlarkBuiltinsFunction

Previously, compute() and computeInline() each were responsible for retrieving exports.bzl using the [non-]inlining code path. This factors them into a common function with an if, for the sake of having fewer differences between these two entrypoints. They now resemble more closely the symmetry between the compute() and computeInline() methods of BzlLoadFunction.

Also, treat InconsistentFilesystemException more like BzlLoadFunction for uniformity, instead of just propagating it up untransformed. This simplifies the function signature and caller obligations.

Misc: Make a codepath in BzlLoadFunction use finally to better capture the intended lifecycle of AST cache entries, at the cost of a bool var.

Work toward #11437.

RELNOTES: None
PiperOrigin-RevId: 326068571
2 files changed
tree: 4e074e20e1bf371a5a0139e4242c3ab129dad081
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status