| commit | c7e8a922a38ea7db29d207fbd43a6af6231c7478 | [log] [tgz] |
|---|---|---|
| author | Jakob Buchgraber <buchgr@google.com> | Wed Jun 19 10:04:26 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jun 19 10:07:01 2019 -0700 |
| tree | 3dad5df2499dbd1ad6c34ba015edab857d9e1f1d | |
| parent | 24cf645480eabbd464f7b7d9b7dbf0669e5c87b6 [diff] |
remote: output files need to be writable. Fixes #8385 They need to be (over)writable by Bazel actions. Closes #8678. PiperOrigin-RevId: 254017428
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java index 1c57b64..97feb0f 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java +++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcher.java
@@ -188,10 +188,9 @@ } try { - path.setReadable(true); - path.setExecutable(true); + path.chmod(0755); } catch (IOException e) { - logger.log(Level.WARNING, "Failed to chmod +xr on " + path, e); + logger.log(Level.WARNING, "Failed to chmod 755 on " + path, e); } }
diff --git a/src/test/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcherTest.java b/src/test/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcherTest.java index b822a4c..7aee9ce 100644 --- a/src/test/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcherTest.java +++ b/src/test/java/com/google/devtools/build/lib/remote/RemoteActionInputFetcherTest.java
@@ -197,6 +197,7 @@ .isEqualTo("hello world"); assertThat(a1.getPath().isExecutable()).isTrue(); assertThat(a1.getPath().isReadable()).isTrue(); + assertThat(a1.getPath().isWritable()).isTrue(); } private Artifact createRemoteArtifact(