commit c8a5eb566e51bdcfe066d8468da11df9bb77680e
author Googler <jingwen@google.com> Tue Jul 23 01:33:55 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jul 23 01:35:35 2024 -0700
tree 1c04c93333efd6cc1b3588f7def17a0eabd098f8
parent f126238259d98b106bec74a72821798dd5ed7d85

Refactorings (avoid auto-boxing, use entrySet over keySet) to CounterSeriesTraceData.

PiperOrigin-RevId: 655072230
Change-Id: I225b7afcc662c3f1f2474b500a33297dc6dd28f7

src/main/java/com/google/devtools/build/lib/profiler/CounterSeriesTraceData.java

diff --git a/src/main/java/com/google/devtools/build/lib/profiler/CounterSeriesTraceData.java b/src/main/java/com/google/devtools/build/lib/profiler/CounterSeriesTraceData.java
index a3436e4..c34f5c0 100644
--- a/src/main/java/com/google/devtools/build/lib/profiler/CounterSeriesTraceData.java
+++ b/src/main/java/com/google/devtools/build/lib/profiler/CounterSeriesTraceData.java
@@ -22,6 +22,7 @@
 import java.io.IOException;
 import java.time.Duration;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.concurrent.TimeUnit;
 import javax.annotation.Nullable;
 
@@ -50,14 +51,15 @@
       Map<ProfilerTask, double[]> counterSeriesMap,
       Duration profileStart,
       Duration bucketDuration) {
-    Integer len = null;
-    for (ProfilerTask profilerTask : counterSeriesMap.keySet()) {
+    int len = -1;
+    for (Entry<ProfilerTask, double[]> entry : counterSeriesMap.entrySet()) {
+      ProfilerTask profilerTask = entry.getKey();
       Preconditions.checkState(
           COUNTER_TASK_TO_SERIES_NAME.containsKey(profilerTask),
           "COUNTER_TASK_TO_SERIES_NAME does not contain %s",
           profilerTask);
-      if (len == null) {
-        len = counterSeriesMap.get(profilerTask).length;
+      if (len == -1) {
+        len = entry.getValue().length;
 
         this.displayName = profilerTask.description;
 
@@ -66,7 +68,8 @@
         // https://github.com/catapult-project/catapult/blob/master/tracing/tracing/base/color_scheme.html
         this.colorName = COUNTER_TASK_TO_COLOR.get(profilerTask);
       } else {
-        Preconditions.checkState(len.equals(counterSeriesMap.get(profilerTask).length));
+        // Check that second and subsequent series have the same length as the first.
+        Preconditions.checkState(len == entry.getValue().length);
       }
     }
     this.len = len;