| commit | c9a2b803eb5e64526e6617c95fa3b0c0891e8ba0 | [log] [tgz] |
|---|---|---|
| author | leba <leba@google.com> | Wed Nov 06 06:45:16 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 06 06:46:14 2019 -0800 |
| tree | 6d6cd9272a1316a53ca6d2dc1f2524285d0aefd7 | |
| parent | 705478f10dcdbf4b0d4dd3f5fefbe37c09a5f73a [diff] |
Use weak-referenced ConcurrentMap to prevent memory leaks. Previously, the concurrent maps in ArtifactNestedSetFunction have strong references to their keys. Therefore, when an Artifact's SkyKey is no longer valid and is removed from Skyframe's map (e.g. when a file is removed from the dependency list), its entry still stays on artifactToSkyValueMap, preventing it from being garbage collected, which results in a memory leak. By having the references being weak, we can prevent this memory leak. Note that this also changes the map's behavior, as it now uses identity instead of the Object#equals method to compare keys. This is mostly fine because: - The SkyKeys aren't repeatedly instantiated for the same Artifact. - This doesn't pollute Skyframe, since the weakmap is completely separated from Skyframe's internal map. RELNOTES: None PiperOrigin-RevId: 278847339
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
