| commit | c9fbe95ef4b93dbf1c25e854b0c6bd82b81b387d | [log] [tgz] |
|---|---|---|
| author | nharmata <nharmata@google.com> | Thu Jun 13 09:39:23 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jun 13 09:40:26 2019 -0700 |
| tree | 5cb468aed348bcbd742a2e7ab26e1d82b8b1de19 | |
| parent | 511eb223b44e327914e048968d13aae6f8f88399 [diff] |
Fix two issues with incremental Skyframe hybrid globbing and the 'allow_empty' param to the 'glob' function (1) Previously, the 'allow_empty=False' enforcement was solely in legacy globbing. So on incremental package evaluation where all the GlobValue nodes already existed in the Skyframe graph, we would not do any enforcement. This was fixed by having by Skyframe globbing and legacy globbing do enforcement. (2) On incremental package evaluation where all the GlobValue nodes already existed in the Skyframe graph, we would still call into legacy globbing with an empty list of glob patterns. Legacy globbing would then error out just as it does normally when a glob *include* pattern matches a bunch of stuff, but then all the matches are removed by an *exclude* pattern. This was fixed by having Skyframe hybrid globbing only call into legacy globbing if there is work to do. I added a bunch of unit tests for various incremental situations. I also added explicit unit tests for 'allow_empty=True'. We were previous missing all/some of this coverage, respectively. Fixes #8517 RELNOTES: None PiperOrigin-RevId: 253046516
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.