| commit | ca0ed609967f1ff9860d29b815bf632139889c4a | [log] [tgz] |
|---|---|---|
| author | William Muir <wamuir@gmail.com> | Wed Oct 27 14:17:00 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Oct 27 14:19:21 2021 -0700 |
| tree | 533739ee619ab2c1d2a6f739317326e1a7f32064 | |
| parent | ec66ded474dcc15c6cf35b56deadef6c9356ac26 [diff] |
Clarify mandatory arguments to config_setting PR removes a statement under the `values` argument to `config_values` which indicates that use of `values` or `define_values` is mandatory (cannot both be empty). The statement appears to contradict [Item 6](https://github.com/bazelbuild/bazel/blob/fad21dae0b01d5f9b2274542c89f4c8163c2ff36/src/main/java/com/google/devtools/build/lib/rules/config/ConfigRuleClasses.java#L385-L390) in notes under `config_setting` and was added prior to the `constraint_values` attribute. Closes #14070. PiperOrigin-RevId: 405978832
diff --git a/src/main/java/com/google/devtools/build/lib/rules/config/ConfigRuleClasses.java b/src/main/java/com/google/devtools/build/lib/rules/config/ConfigRuleClasses.java index cb03fbf..7f39dba 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/config/ConfigRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/rules/config/ConfigRuleClasses.java
@@ -182,10 +182,6 @@ <code>bazel build --copt=foo --copt=bar --copt=baz ...</code>), a match occurs if <i>any</i> of those settings match. <p> - - <p>This and <a href="${link config_setting.define_values}"><code>define_values</code></a> - cannot both be empty. - </p> <!-- #END_BLAZE_RULE.ATTRIBUTE --> */ .add( attr(SETTINGS_ATTRIBUTE, STRING_DICT)