commit cab889d3ec9dff37dfa316aa790f3e5fecceed8a
author michajlo <michajlo@google.com> Thu Feb 20 17:48:36 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Feb 20 17:49:24 2020 -0800
tree 5c184153e4cfd175110a4ef83e7f2839aea959f5
parent e2fce442d0ba341313a94a0b85f31f0e3b521985

Lift PackageArgument and default package arguments out of PackageFactory

PakcageArgument seems like a popular enough thing to live in its own top-level
java file. The default arguments (I think that's a fair term(?)) are unrelated
to PackageFactory enough to justify hiding away in their own class. The end
result is we can now see (many of) PackageFactory's instance members without
having to scroll (there are still some scattered elsewhere in the class).

Also moved PackageFactory.getVisibility -> PackageUtils.getVisibility in order
to avoid a benign but awkard circular dependency.

RELNOTES: None
PiperOrigin-RevId: 296337425

src/main/java/com/google/devtools/build/lib/packages/RuleClass.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
index 4e78bea..0d9156c 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
@@ -2228,7 +2228,7 @@
             eventHandler);
       }
       try {
-        rule.setVisibility(PackageFactory.getVisibility(rule.getLabel(), attrList));
+        rule.setVisibility(PackageUtils.getVisibility(rule.getLabel(), attrList));
       } catch (EvalException e) {
          rule.reportError(rule.getLabel() + " " + e.getMessage(), eventHandler);
       }