commit cb3d799cc89276c9b1d9185e5556df870abec1c9
author Florian Weikert <fwe@google.com> Tue Sep 06 14:54:22 2016 +0000
committer Kristina Chodorow <kchodorow@google.com> Tue Sep 06 15:39:59 2016 +0000
tree 84766f86959474ca9844b0c9c208c285d578200f
parent 304f5cbfac3c8cc272a0c43d3077a4cff0e1cc5a

Skylark no longer crashes when the default value of an attribute is a label string that points to a remote repository.

Fixes #1442.

--
MOS_MIGRATED_REVID=132320130

src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java b/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
index ea52e11..2e4bbb6 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
@@ -172,7 +172,7 @@
             new SkylarkComputedDefaultTemplate(
                 type, callback.getParameterNames(), callback, ast.getLocation()));
       } else {
-        builder.defaultValue(defaultValue);
+        builder.defaultValue(defaultValue, env.getGlobals().label());
       }
     }