commit cb601a01113fddc5a7d635d472dd8fbb6323e21d
author Googler <tjgq@google.com> Mon Oct 28 06:56:24 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Oct 28 06:58:20 2024 -0700
tree 7d7294a39a008069eda2650749a85ed3331f4ddd
parent 81f612538f620634f8bf9adba4436489a1596071

Correctly compute the number of threads to use for garbage collection.

We want a lower bound, not an upper one.

PiperOrigin-RevId: 690593852
Change-Id: If391e695593c9d445b4968be98d05e6169a06b3a

src/tools/diskcache/Gc.java

diff --git a/src/tools/diskcache/Gc.java b/src/tools/diskcache/Gc.java
index c678e5b..04eeed4 100644
--- a/src/tools/diskcache/Gc.java
+++ b/src/tools/diskcache/Gc.java
@@ -13,7 +13,7 @@
 // limitations under the License.
 package diskcache;
 
-import static java.lang.Math.min;
+import static java.lang.Math.max;
 
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 import com.google.devtools.build.lib.remote.disk.DiskCacheGarbageCollector;
@@ -75,7 +75,7 @@
 
   private static final ExecutorService executorService =
       Executors.newFixedThreadPool(
-          min(4, Runtime.getRuntime().availableProcessors()),
+          max(4, Runtime.getRuntime().availableProcessors()),
           new ThreadFactoryBuilder().setNameFormat("disk-cache-gc-%d").build());
 
   public static void main(String[] args) throws Exception {