commit cdb17bde1142d3a1201d58d583965106be6d4adb
author Klaus Aehlig <aehlig@google.com> Tue Jul 12 15:18:33 2016 +0000
committer Kristina Chodorow <kchodorow@google.com> Wed Jul 13 11:15:35 2016 +0000
tree 88137071eb2b82bb16caebe7843b0d89a8cb4a19
parent bb1e78e0d6f69ea12cbf410ffea6e67bee318306

Rollback of commit feb1321044e3b7be34f9c1d7dacf9881d99a7327.

*** Reason for rollback ***

Underlying issue fixed in commit 5b12f6e759c1f3137a7149d3026ff96686d07696

*** Original change description ***

Automated [] rollback of commit a3381b6ac136a0cab3ba86020c739fe16b42cee9.

*** Reason for rollback ***

Broke bazel_rules_test

See https://github.com/bazelbuild/bazel/issues/1501.

*** Original change description ***


Fix default for temporary directories to honor TMPDIR

...and only use the hard-coded "/tmp" as default for the default.
Note that is unchanged that blaze.rpcserver.tmpdir still overrides.

--
MOS_MIGRATED_REVID=127201018

src/main/java/com/google/devtools/build/lib/server/AfUnixServer.java

diff --git a/src/main/java/com/google/devtools/build/lib/server/AfUnixServer.java b/src/main/java/com/google/devtools/build/lib/server/AfUnixServer.java
index f615d04..8c5d316 100644
--- a/src/main/java/com/google/devtools/build/lib/server/AfUnixServer.java
+++ b/src/main/java/com/google/devtools/build/lib/server/AfUnixServer.java
@@ -329,7 +329,14 @@
     // (All this extra complexity is just used in tests... *sigh*).
     if (socketFile.toString().length() >= 104) { // = UNIX_PATH_MAX
       Path socketLink = socketFile;
-      String tmpDir = System.getProperty("blaze.rpcserver.tmpdir", "/tmp");
+      String tmpDirDefault = System.getenv("TMPDIR");
+      if (tmpDirDefault == null
+          || tmpDirDefault.length() > 104 - "/blaze-4294967296/server.socket".length()) {
+        // Default for unset TMPDIR, or if TMPDIR is so that the resulting
+        // path would be too long.
+        tmpDirDefault = "/tmp";
+      }
+      String tmpDir = System.getProperty("blaze.rpcserver.tmpdir", tmpDirDefault);
       socketFile = createTempSocketDirectory(socketFile.getRelative(tmpDir)).
           getRelative("server.socket");
       LOG.info("Using symlinked socket at " + socketFile);