| commit | ce0335a31b229e2de530f746807f3790b7c20111 | [log] [tgz] |
|---|---|---|
| author | nharmata <nharmata@google.com> | Wed Nov 13 15:48:05 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 13 15:48:59 2019 -0800 |
| tree | 7e98f3cf6a0c660128b2f752361ae14ad6f12322 | |
| parent | 3a57a5276a0694fffab3d40fef8a42a1bc44680d [diff] |
Prefer rethrowing Skyframe globbing errors rather than legacy globbing errors. Skyframe globbing errors are more useful to the user (e.g. in the case of a symlink cycle, the error message contains the cycle) and are also persistent. Contrast with legacy globbing errors which are more opaque and are conservatively assumed to be transient. Unsurprisingly, this change fixes a long-standing discrepancy between incremental and non-incremental package loading. The new, self-consistent behavior, is that PackageFunction will throw a NoSuchPackageException if any glob evaluation encounters a symlink cycle, regardless if glob evaluations were cached via Skyframe globbing. The discrepancy with the old code was that legacy globbing ignores some symlink issues (see UnixGlob.GlobVisitor#processSymlink), and so on non-incremental package loading with a symlink ignored by legacy globbing, PackageFunction wouldn't throw a NoSuchPackageException. RELNOTES: Package loading now consistently fails if package loading had a glob evaluation that encountered a symlink cycle or symlink infinite expansion. Previously, such package loading with such glob evaluations would fail only in some cases. PiperOrigin-RevId: 280298226
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
