commit cfd681f6118ef40e51d980d786c6e9b4b3aa66f3
author Googler <noreply@google.com> Mon Nov 11 07:24:02 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Nov 11 07:24:58 2019 -0800
tree 822ea5275426dba97a8b5c1a0bd0c505557985dc
parent 0af987ba35686826a6e4baf5bf8712b00a327b11

bazel syntax: rename SkylarkList.Tuple to Tuple

Tuple is one of the core data types of Starlark.
SkylarkList, which should be named Sequence, is the interface common to all indexable sequences.

Also, remove is SkylarkList.isTuple method.
The only class that isTuple is Tuple.

By a minor miracle, there were no references to Tuple from within the
copybara code base, so this renaming is unusually straightforward.

PiperOrigin-RevId: 279730954

src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
index ec4a25e..672fee8 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
@@ -1682,10 +1682,7 @@
             "  t2 += (3, 4)",
             "  return t1, t2",
             "tuples = func()")
-        .testLookup("tuples", SkylarkList.Tuple.of(
-            SkylarkList.Tuple.of(1, 2),
-            SkylarkList.Tuple.of(1, 2, 3, 4)
-        ));
+        .testLookup("tuples", Tuple.of(Tuple.of(1, 2), Tuple.of(1, 2, 3, 4)));
   }
 
   @Test
@@ -2024,11 +2021,11 @@
     // tuple
     x = eval("(1,2)");
     assertThat((Iterable<Object>) x).containsExactly(1, 2).inOrder();
-    assertThat(((SkylarkList) x).isTuple()).isTrue();
+    assertThat(x).isInstanceOf(Tuple.class);
 
     x = eval("(1,2) + (3,4)");
     assertThat((Iterable<Object>) x).containsExactly(1, 2, 3, 4).inOrder();
-    assertThat(((SkylarkList) x).isTuple()).isTrue();
+    assertThat(x).isInstanceOf(Tuple.class);
   }
 
   @Override