commit d03f32142ca0e05cc87855337557f8ea33972658
author Han-Wen Nienhuys <hanwen@google.com> Tue Jan 19 16:21:57 2016 +0000
committer Han-Wen Nienhuys <hanwen@google.com> Wed Jan 20 11:33:52 2016 +0000
tree c96bdbf6afb5c4dfbb28ec024b4da73d6aeaee71
parent 4bdbf338814e38b2fb5ff7033eb4d98c8e0798ff

Replace %{product} in option help texts too.

Fixes #730.

--
MOS_MIGRATED_REVID=112475309

src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandUtils.java

diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandUtils.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandUtils.java
index 3f14471..3ba6e22 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandUtils.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandUtils.java
@@ -131,15 +131,19 @@
       throw new IllegalStateException("Help template for '" + topic + "' omits %{options}!");
     }
 
-    return template.
-        replace("%{product}", Constants.PRODUCT_NAME).
-        replace("%{command}", topic).
-        replace("%{options}", parser.describeOptions(categoryDescriptions, helpVerbosity)).
-        trim()
+    String optionStr =
+        parser
+            .describeOptions(categoryDescriptions, helpVerbosity)
+            .replace("%{product}", Constants.PRODUCT_NAME);
+    return template
+            .replace("%{product}", Constants.PRODUCT_NAME)
+            .replace("%{command}", topic)
+            .replace("%{options}", optionStr)
+            .trim()
         + "\n\n"
         + (helpVerbosity == OptionsParser.HelpVerbosity.MEDIUM
-           ? "(Use 'help --long' for full details or --short to just enumerate options.)\n"
-           : "");
+            ? "(Use 'help --long' for full details or --short to just enumerate options.)\n"
+            : "");
   }
 
   /**