commit d052ececddf54587c576f876ce13d4b8f4aacb0b
author Philipp Schrader <philipp.schrader@gmail.com> Tue Mar 16 08:11:30 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 16 08:12:19 2021 -0700
tree ab1b4cf8feee07221057ae8ba1f27fe4ede528f7
parent ec176838f2a278b2429319d80cc419cbe45d4904

Expand target_compatible_with to all non-workspace rules

This patch makes it so the `target_compatible_with` attribute can be
used with all non-workspace rules. The motivation here is to allow
rules like `filegroup` and `cc_import` to also make use of
incompatible target skipping. Even though these rules don't
inherently generate files that are incompatible with the target
platform, they can be used to provide incompatible files to other
targets. Before this patch the user had to do something like this to
create an incompatible pre-compiled library:

    cc_import(
        name = "foo_import",
        shared_library = "foo.so",
    )

    cc_library(
        name = "foo",
        deps = [":foo_import"],
        target_compatible_with = ["//:foo_platform"],
    )

Now users can directly declare compatibility on the `cc_import` rule.

    cc_import(
        name = "foo_import",
        shared_library = "foo.so",
        target_compatible_with = ["//:foo_platform"],
    )

Unfortunately, This does mean that some rules like `cc_toolchain` now
have a `target_compatible_with` that doesn't serve any purpose.

Before the changes in `BaseRulesClasses.java` the test would error out
with meesages like this:

    //target_skipping:some_precompiled_library: no such attribute 'target_compatible_with' in 'cc_import' rule
    //target_skipping:filegroup: no such attribute 'target_compatible_with' in 'filegroup' rule

I also took this opportunity to update the documentation a bit.

Fixes #12745

Closes #13170.

PiperOrigin-RevId: 363185186