commit d21345dea13a8d46475cf29563a64a7fbd2d6b35
author Grzegorz Lukasik <glukasik@nuro.ai> Tue Aug 17 19:24:16 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Aug 17 19:25:41 2021 -0700
tree faf109dcf5639b094e57a3c4dfe73148b2d9ddff
parent b8764e471673f4799cc33b80d1aeae452b4f932c

Remove noisy logs from UrlRewriter.

UrlRewriter prints log for each URL that is rewritten, in form of
`Rewritten %s as %s`. This causes tens of long logs to be printed,
making logs very noisy.

See also https://github.com/bazelbuild/bazel/issues/13764.

Closes #13806.

PiperOrigin-RevId: 391431109

src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/UrlRewriter.java

diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/UrlRewriter.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/UrlRewriter.java
index a814559..d52a3f5 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/UrlRewriter.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/UrlRewriter.java
@@ -55,12 +55,10 @@
 
   private final UrlRewriterConfig config;
   private final Function<URL, List<URL>> rewriter;
-  private final Consumer<String> log;
 
   @VisibleForTesting
   UrlRewriter(Consumer<String> log, String filePathForErrorReporting, Reader reader)
       throws UrlRewriterParseException {
-    this.log = Preconditions.checkNotNull(log);
     Preconditions.checkNotNull(reader, "UrlRewriterConfig source must be set");
     this.config = new UrlRewriterConfig(filePathForErrorReporting, reader);
 
@@ -102,10 +100,6 @@
     ImmutableList<URL> rewritten =
         urls.stream().map(rewriter).flatMap(Collection::stream).collect(toImmutableList());
 
-    if (!urls.equals(rewritten)) {
-      log.accept(String.format("Rewritten %s as %s", urls, rewritten));
-    }
-
     return rewritten;
   }