| commit | d4b10dde68d85a223e61f692c99eaef0aa0528cb | [log] [tgz] |
|---|---|---|
| author | Robin Nabel <rnabel@ucdavis.edu> | Wed Jun 03 11:30:34 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jun 03 11:32:01 2020 -0700 |
| tree | 91071d543574827828a047aea0f270e5d48b7fed | |
| parent | 7f4befa61034a22a748502bb3265585a0094f145 [diff] |
Fix `--run_under` Windows escaping bug Fixes #10993. The argument escaping that happens in [line 517](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java#L516) violates the invariant assumed by [`AsWindowsPath()`](https://github.com/bazelbuild/bazel/blob/master/src/main/cpp/util/path_windows.cc#L245) on the client, which is called when ensuring that the binary path is absolute ([`AsAbsoluteWindowsPathImpl`](https://github.com/bazelbuild/bazel/blob/master/src/main/cpp/util/path_windows.cc#L323)). `AsWindowsPathImpl` clearly assumes that the passed string is not quoted (i.e. it is either empty, `/` or contains a drive letter: `C:\`, etc.) PR verification: Follow the steps outlined in the repro case for #10993, but use `--run_under=":;"` which is a valid prefix for a windows binary run from within bash (the original repro case used --run_under=cmd, which is not a valid way to execuate a binary if I understand `cmd`'s cryptic error message correctly). Testing: The PR is missing a test case - any pointers as to how to add a unit test for this bug would be much appreciated. Closes #11537. PiperOrigin-RevId: 314570235
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
