| commit | d5352f851b7e11d2c3738214f67a91029bbfe284 | [log] [tgz] |
|---|---|---|
| author | Jingwen Chen <jingwen@google.com> | Mon Mar 02 10:23:52 2020 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Mar 02 10:25:01 2020 -0800 |
| tree | c1e27cd68e68f7cd390b91065145435b832f8840 | |
| parent | c6244b29effac57ecb0c367e8deec580fe7e9fbd [diff] |
Ninja integration: parse "pool" declarations and identifiers in rules
This adds a new parser to parse "pool" declarations and "pool" identifiers in Ninja rules, and adds them into NinjaScope. We currently don't do anything special with these yet, and are just doing enough so that we parse Ninja files correctly.
Without this, the following will fail:
```ninja
rule some_name
pool = some_pool
command = echo hello
```
```starlark
ninja_graph(
name = "simple",
main = "simple.ninja",
ninja_srcs = [
"simple.ninja",
],
output_root = "out",
)
```
```
ERROR: in ninja_graph rule //:simple: Expected [IDENTIFIER], but got pool in fragment:
rule some_name
pool = some_pool
command = echo hello
ERROR: Analysis of target '//:simple' failed; build aborted: Analysis of target '//:simple' failed; build aborted
FAILED: Build did NOT complete successfully (6 packages loaded, 11 targets configured)
```
Closes #10868.
PiperOrigin-RevId: 298385134
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
