| commit | 0287d927d92c0b0cb514e97120461b3df563c37f | [log] [tgz] |
|---|---|---|
| author | Googler <brandjon@google.com> | Fri Jan 26 13:12:20 2024 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Jan 26 13:14:02 2024 -0800 |
| tree | bb2825eeb283c6fce8640964004a79bdf2728f19 | |
| parent | 3d4491c9ab0c063356d3c017a9308c50fa604294 [diff] |
Evaluate macro implementation functions https://github.com/bazelbuild/bazel/commit/09eef85a7348d6cf2ddaaad007c1d57ae5a12570 added the ability to declare symbolic macros in packages, but did not run their implementation functions. This CL adds that feature. For now, implementation functions run synchronously with the call that instantiates the macro. The implementation runs in its own Starlark thread, but it has the side effect of mutating the original Package.Builder, so the targets that it declares are visible to native.existing_rules() in legacy macros. In the future we may make symbolic macro evaluation lazy, in which case the implementation function would run sometime after BUILD evaluation completes, and macro-generated targets would be invisible to native.existing_rules(). MacroClass.java: - add static helper executeMacroImplementation(). This is analogous to PackageFactory#executeBuildFileImpl(), but I prefer to not weigh that file down with additional code. SymbolicMacroTest.java: - tests for signature of implementation function - test for macro-generated targets. Note that the "my_macro$my_target" naming convention isn't enforced yet. - test for macro composability - test for calling existing_rules and glob in a symbolic macro. These will be inverted in a later CL when we ban them, by supplying a different class than Package.Builder to executeMacroImplementation(). Work toward #19922. PiperOrigin-RevId: 601848482 Change-Id: Ic70fdad9e7d8323c76a3f0125c518547adeee96f
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
