| commit | db27113f8fd60ed964f3f9d0c5bf086cde430db7 | [log] [tgz] |
|---|---|---|
| author | gregce <gregce@google.com> | Mon Apr 05 15:50:50 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Apr 05 15:51:58 2021 -0700 |
| tree | c87f64517e6df8ef66d9beda29ee1f8a52931177 | |
| parent | 036fc388059a7676ee9e03a1c3df5029f749fe62 [diff] |
Stop the Android dexer from using legacy toolchains with platforms. This is way more complicated than you would expect. Short story is the Android dexing aspect automatically propagates down the ":android_sdk" attribute, which references the legacy toolchain. This dexes needed .jars in the toolchain's deps (and those deps can appear in any package, so we can't easily identify them by filtering for the toolchain's package). With platform-based toolchains, this breaks builds due to both types of toolchains being read in different places and mixing poorly. See code comments for details. The only real solution is to *never* propagate down ":android_sdk" with platforms. This is also good general design: ":android_sdk" should have no influence on platform-based Android builds under any circumstances. But aspects have no mechanism to conditionally skip propagation. So this change adds a small API extension to aspects to support that. It's a classic case of a generic API to support an exceptional situation, so comments are also included not to use it for other purposes. PiperOrigin-RevId: 366890107
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
