commit db36147bc66109cc2f34bcdb5bb8829182ef0346
author Googler <noreply@google.com> Tue Mar 29 02:41:57 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 29 02:43:15 2022 -0700
tree af196af8c1be813c08a581e56ad8b49476d8946a
parent 13ae2c617e1a8d18dd35986b930d5accef82ac38

Restrict cc_binary and cc_test "stamp" attribute values to [-1, 0, 1].

PiperOrigin-RevId: 437974916

src/main/starlark/builtins_bzl/common/cc/cc_binary_attrs.bzl

diff --git a/src/main/starlark/builtins_bzl/common/cc/cc_binary_attrs.bzl b/src/main/starlark/builtins_bzl/common/cc/cc_binary_attrs.bzl
index 446c738..fd51f7f 100644
--- a/src/main/starlark/builtins_bzl/common/cc/cc_binary_attrs.bzl
+++ b/src/main/starlark/builtins_bzl/common/cc/cc_binary_attrs.bzl
@@ -70,6 +70,7 @@
         aspects = [graph_structure_aspect],
     ),
     "stamp": attr.int(
+        values = [-1, 0, 1],
         default = -1,
     ),
     "linkshared": attr.bool(

src/main/starlark/builtins_bzl/common/cc/cc_test.bzl

diff --git a/src/main/starlark/builtins_bzl/common/cc/cc_test.bzl b/src/main/starlark/builtins_bzl/common/cc/cc_test.bzl
index 51ee6c5..6939ad8 100644
--- a/src/main/starlark/builtins_bzl/common/cc/cc_test.bzl
+++ b/src/main/starlark/builtins_bzl/common/cc/cc_test.bzl
@@ -28,7 +28,7 @@
 # Update cc_test defaults:
 _cc_test_attrs.update(
     _is_test = attr.bool(default = True),
-    stamp = attr.int(default = 0),
+    stamp = attr.int(values = [-1, 0, 1], default = 0),
     linkstatic = attr.bool(default = False),
     malloc = attr.label(
         default = Label("@//tools/cpp:cc_test_malloc"),