| commit | df38c206022d89958cef89f3ce64ed9b22c8aa6b | [log] [tgz] |
|---|---|---|
| author | Googler <brandjon@google.com> | Thu Aug 08 09:59:47 2024 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Aug 08 10:02:07 2024 -0700 |
| tree | 6465f3ac09f8471b002579ec9d0996351d07d368 | |
| parent | 5ccf45a230d5a39d5d9722dc3c1ccb8a7c6b23cd [diff] |
Make the symbolic macro invocation stack implicit It turns out that we never really need to access outer macros. This CL makes the stack management done by the caller (MacroClass#executeMacroImplementation). This paves the way for evaluating individual symbolic macros outside of the context in which they were declared, e.g. deferred until the end of BUILD file evaluation. That in turn is needed to implement rule finalizers. Package.java - Replace macroStack with currentMacroFrame, representing what was previously the top item of macroStack. - Rename MactoStackFrame to just MacroFrame and make it package-visible for use by MacroClass. - Rename currentMacroFrame() -> getCurrentMacroFrame and make package-visible. - Replace [push|pop]Macro() with [get|set]CurrentMacroFrame(). - Remove other helpers for accessing current macro info, undoing the convenience API added in the recent prior CL. Now that it's a simpler data struture the extra machinery isn't warranted. MacroClass.java - Update instantiateMacro() for use of MacroFrame type. - Update executeMacroImplementation to save the old frame on the stack, push a new one, and restore it, including in case of EvalException / InterruptedException / unchecked exception. Work toward #19922. PiperOrigin-RevId: 660878222 Change-Id: I13f278f6c61afade8e5923f549f480009205685b
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
