commit dce9c45b18f6ca163a11645b8d8e555dd6113fb1
author shahan <shahan@google.com> Fri Oct 12 06:45:27 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Fri Oct 12 06:47:51 2018 -0700
tree 076aa63c5a167bf4ad048dcb20782bb3b9a0c82e
parent 1ca8099fc100d25683e5a7f94a5ad1a184fe2a96

Removes Unshareable tag from PrecomputedValue (it causes invalidations).

Makes BUILD_CONFIGURATION public.

PiperOrigin-RevId: 216855028

src/main/java/com/google/devtools/build/lib/skyframe/PrecomputedValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PrecomputedValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/PrecomputedValue.java
index 08f573e..937e59c 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PrecomputedValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PrecomputedValue.java
@@ -27,7 +27,6 @@
 import com.google.devtools.build.lib.packages.RuleVisibility;
 import com.google.devtools.build.lib.pkgcache.PathPackageLocator;
 import com.google.devtools.build.lib.skyframe.SkyframeActionExecutor.ConflictException;
-import com.google.devtools.build.lib.skyframe.serialization.UnshareableValue;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
 import com.google.devtools.build.lib.syntax.SkylarkSemantics;
 import com.google.devtools.build.skyframe.AbstractSkyKey;
@@ -46,7 +45,7 @@
  * (e.g. via injection).
  */
 @AutoCodec
-public final class PrecomputedValue implements SkyValue, UnshareableValue {
+public final class PrecomputedValue implements SkyValue {
   /**
    * An externally-injected precomputed value. Exists so that modules can inject precomputed values
    * into Skyframe's graph.

src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
index c21ce5c..703dc7b 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java
@@ -104,7 +104,7 @@
   static final SkyFunctionName TEST_COMPLETION =
       SkyFunctionName.create(
           "TEST_COMPLETION", ShareabilityOfValue.NEVER, FunctionHermeticity.HERMETIC);
-  static final SkyFunctionName BUILD_CONFIGURATION =
+  public static final SkyFunctionName BUILD_CONFIGURATION =
       SkyFunctionName.createHermetic("BUILD_CONFIGURATION");
   public static final SkyFunctionName CONFIGURATION_FRAGMENT =
       SkyFunctionName.createHermetic("CONFIGURATION_FRAGMENT");