| commit | de8d4c7bddb729d3703c97c6bee58062e154ec34 | [log] [tgz] |
|---|---|---|
| author | jmmv <jmmv@google.com> | Thu Sep 12 11:12:25 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Sep 12 11:13:26 2019 -0700 |
| tree | 0f7ea4eba51a7b723bed5187df53e865065edb53 | |
| parent | a235269feb87e080a80f9a6c1428a52704829a5a [diff] |
Wait for process termination when the LocalSpawnRunner is interrupted. The dynamic scheduler cancels the futures it uses to run spawns, which causes the spawns executed via the LocalSpawnRunner to be interrupted. Once interrupted, the spawn runner kills the subprocess... but it was not waiting for the subprocess' termination. This could lead to races because signal delivery is not synchronous and the subprocess might continue running for a little bit while the dynamic scheduler decides to do something else with the other (remote) spawn. I haven't observed these races in the wild, but I'm seeing problems while modifying the dynamic scheduler to forcibly cancel local spawns once we have scored a cache hit. To fix this problem, make the LocalSpawnRunner wait for process termination after it forcibly destroys the subprocess on interrupt. And, while doing so, homogenize all (?) the places where we try to forcibly terminate subprocesses. Addresses issue #7818. RELNOTES: None. PiperOrigin-RevId: 268724818
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.